Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

criu: Allow disabling freeze cgroups #2475

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

avagin
Copy link
Member

@avagin avagin commented Sep 12, 2024

Some plugins (e.g., CUDA) may not function correctly when processes are frozen using cgroups. This change introduces a mechanism to disable the use of freeze cgroups during process seizing, even if explicitly requested via the --freeze-cgroup option.

Fixes #2470

Copy link
Contributor

@jesus-ramos jesus-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the CUDA side, thanks Andrei.

criu/seize.c Show resolved Hide resolved
criu/fault-injection.c Dismissed Show dismissed Hide dismissed
criu/seize.c Outdated Show resolved Hide resolved
Some plugins (e.g., CUDA) may not function correctly when processes are
frozen using cgroups. This change introduces a mechanism to disable the
use of freeze cgroups during process seizing, even if explicitly
requested via the --freeze-cgroup option.

The CUDA plugin is updated to utilize this new mechanism to ensure
compatibility.

Signed-off-by: Andrei Vagin <[email protected]>
Adds a new "fault" to call dont_use_freeze_cgroup.
@avagin avagin force-pushed the cude-vs-cgroup-freezer branch from f638b6c to 895a7a7 Compare September 13, 2024 14:09
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avagin avagin merged commit 1190f10 into checkpoint-restore:criu-dev Sep 14, 2024
37 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants